Preparing report...

Report for github.com/DeedleFake/p9

A+    Excellent!    Found 9 issues across 35 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo94%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • p9/fs.go
    • Line 436: warning: cyclomatic complexity 16 of function (*fsHandler).read() is high (> 15) (gocyclo)

golint80%

Golint is a linter for Go source code.

    • p9/stat.go
    • Line 191: warning: exported method Stat.P9Encode should have comment or be unexported (golint)
    • Line 217: warning: exported method Stat.P9Decode should have comment or be unexported (golint)
    • Line 289: warning: exported method DirEntry.Name should have comment or be unexported (golint)
    • Line 293: warning: exported method DirEntry.Size should have comment or be unexported (golint)
    • Line 297: warning: exported method DirEntry.Mode should have comment or be unexported (golint)
    • Line 301: warning: exported method DirEntry.ModTime should have comment or be unexported (golint)
    • Line 305: warning: exported method DirEntry.IsDir should have comment or be unexported (golint)
    • Line 309: warning: exported method DirEntry.Sys should have comment or be unexported (golint)
    • Line 320: warning: exported method StatChanges.Mode should have comment or be unexported (golint)
    • Line 324: warning: exported method StatChanges.ATime should have comment or be unexported (golint)
    • Line 328: warning: exported method StatChanges.MTime should have comment or be unexported (golint)
    • Line 332: warning: exported method StatChanges.Length should have comment or be unexported (golint)
    • Line 336: warning: exported method StatChanges.Name should have comment or be unexported (golint)
    • Line 340: warning: exported method StatChanges.UID should have comment or be unexported (golint)
    • Line 344: warning: exported method StatChanges.GID should have comment or be unexported (golint)
    • Line 348: warning: exported method StatChanges.MUID should have comment or be unexported (golint)
    • p9/cmd/p9w/p9w.go
    • Line 21: warning: exported const AddrKey should have comment (or a comment on this block) or be unexported (golint)
    • Line 26: warning: exported function Error should have comment or be unexported (golint)
    • Line 42: warning: exported function AttachHandler should have comment or be unexported (golint)
    • Line 83: warning: exported function DispositionHandler should have comment or be unexported (golint)
    • p9/proto/server.go
    • Line 127: warning: exported method ConnHandlerFunc.MessageHandler should have comment or be unexported (golint)
    • Line 144: warning: exported method MessageHandlerFunc.HandleMessage should have comment or be unexported (golint)
    • p9/cmd/p9/p9.go
    • Line 17: warning: exported type Command should have comment or be unexported (golint)
    • Line 28: warning: exported function GetCommand should have comment or be unexported (golint)
    • Line 38: warning: exported function RegisterCommand should have comment or be unexported (golint)
    • Line 125: warning: exported type GlobalOptions should have comment or be unexported (golint)
    • p9/msg.go
    • Line 79: warning: exported type Tversion should have comment or be unexported (golint)
    • Line 84: warning: exported method Tversion.P9NoTag should have comment or be unexported (golint)
    • Line 86: warning: exported type Rversion should have comment or be unexported (golint)
    • Line 91: warning: exported method Rversion.P9Msize should have comment or be unexported (golint)
    • Line 95: warning: exported type Tauth should have comment or be unexported (golint)
    • Line 101: warning: exported type Rauth should have comment or be unexported (golint)
    • Line 105: warning: exported type Tattach should have comment or be unexported (golint)
    • Line 112: warning: exported type Rattach should have comment or be unexported (golint)
    • Line 126: warning: exported type Tflush should have comment or be unexported (golint)
    • Line 130: warning: exported type Rflush should have comment or be unexported (golint)
    • Line 133: warning: exported type Twalk should have comment or be unexported (golint)
    • Line 139: warning: exported type Rwalk should have comment or be unexported (golint)
    • Line 143: warning: exported type Topen should have comment or be unexported (golint)
    • Line 148: warning: exported type Ropen should have comment or be unexported (golint)
    • Line 153: warning: exported type Tcreate should have comment or be unexported (golint)
    • Line 160: warning: exported type Rcreate should have comment or be unexported (golint)
    • Line 165: warning: exported type Tread should have comment or be unexported (golint)
    • Line 171: warning: exported type Rread should have comment or be unexported (golint)
    • Line 175: warning: exported type Twrite should have comment or be unexported (golint)
    • Line 181: warning: exported type Rwrite should have comment or be unexported (golint)
    • Line 185: warning: exported type Tclunk should have comment or be unexported (golint)
    • Line 189: warning: exported type Rclunk should have comment or be unexported (golint)
    • Line 192: warning: exported type Tremove should have comment or be unexported (golint)
    • Line 196: warning: exported type Rremove should have comment or be unexported (golint)
    • Line 199: warning: exported type Tstat should have comment or be unexported (golint)
    • Line 203: warning: exported type Rstat should have comment or be unexported (golint)
    • Line 207: warning: exported method Rstat.P9Encode should have comment or be unexported (golint)
    • Line 219: warning: exported method Rstat.P9Decode should have comment or be unexported (golint)
    • Line 235: warning: exported type Twstat should have comment or be unexported (golint)
    • Line 240: warning: exported method Twstat.P9Encode should have comment or be unexported (golint)
    • Line 257: warning: exported method Twstat.P9Decode should have comment or be unexported (golint)
    • Line 278: warning: exported type Rwstat should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!